Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api/middleware/auth.ts: public-methods list had lowercase"post", so POST never matched; now"POST"(policy comment and tests expect public POST).api/routes/users.ts: added missingbadRequestimport (runtime ReferenceError + tsc error).shared/types.ts: renamedUser.userName→usernameto match routes/tests.shared/utils/pagination.ts: implementedpaginate(1-indexed pages,totalPages = ceil(total/size), empty data for out-of-range pages).tsconfig.json: added"types": ["bun-types"](already a devDependency) so tsc resolvesbun:test/process.Result:
bun test22/22 pass,tsc --noEmitclean.Assumptions / follow-ups (not changed — out of scope "fix only what tests require")
paginatedoes not validate negative/zero/non-integerpage/size; no caller passes user input yet. Recommend adding guards + tests before wiring into routes.auth.tsfalls back to hard-coded"test-token"whenAPI_TOKENis unset and uses non-constant-time compare;bun-typesis pinned tolatest.// BUG/ TODO comments left in place.